Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ubuntu/windows) avoid tragedy of commons goods: use dlcdn apache download server for Maven #1603

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Dec 15, 2024

Same as jenkins-infra/github-reusable-workflows#41 + jenkins-infra/github-reusable-workflows#39

We want to avoid the Tragedy of Common Goods and as such we should only download binaries from the recommended sources.

In the case of Maven, using the Apache CDN instead of archives is the least we can do to decrease our hammering of the Apache public INFRA, and also to decrease chances of failing builds for us.

Note: jenkins-infra/github-reusable-workflows#39 (comment) shows that there might be "different/better" sources. Worth discussing and changing again, but this PR is a first step.

@dduportal dduportal requested a review from smerle33 December 15, 2024 15:08
@dduportal dduportal marked this pull request as ready for review December 15, 2024 15:08
@dduportal dduportal added bug Something isn't working windows ubuntu maven labels Dec 15, 2024
Copy link
Contributor

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dduportal dduportal merged commit efdd950 into main Dec 17, 2024
2 checks passed
@dduportal dduportal deleted the dduportal-patch-1 branch December 17, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maven ubuntu windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants